[AMS] Merle Jansen #727
Open
[AMS] Merle Jansen #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lienekechee
reviewed
Feb 28, 2019
lienekechee
left a comment
lienekechee
left a comment
There was a problem hiding this comment.
Nice merle, everything looks neat! let's try to find a way next time we do something similar to reduce duplicate code, and change classes in the starter code if you need to :)
| sum -=1; | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
Perhaps it might be useful here to create two functions that could help you avoid duplicate code:
e.g. calculatePrice() and toggleIngredient() for example. A function like setupDefaultToppings() might also be handy in terms of readability. Then the challenge is, how can you define and organize your classes to be able to do these things for every ingredient with one function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.