completed #728
Open
completed #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lienekechee
reviewed
Feb 27, 2019
| var pizzaTotalPrice = [{ type: '', price: 0 }]; | ||
|
|
||
| // create object containing base pizza price | ||
|
|
There was a problem hiding this comment.
Would be super nice to use a constructor function here!
function Topping(type, price) {
}
| type: "greenPepperTopping", | ||
| price: 1 | ||
| }); | ||
|
|
There was a problem hiding this comment.
Let's try our best to avoid duplicate code; normally if you have to repeat the same kind of thing over and over again, its more appropriate to write a function, this is what they are for. Some things to think about when setting up your program:
- What are the collections of data that I need to store? Since your toppings and your prices don't change, we can declare them immediately in an array, and have a separate array for prices. Maybe even the type strings can correspond to the class name of the button. Do you see how that might be helpful?
- There are default settings for this pizza page. Perhaps setting up all your variables in one place then writing a
setupDefaultView()function that sets up initial toppings and prices, or something similar, could be a little clearer.
|
|
||
| // array to calc final pizza price | ||
| var pizzaTotalPrice = [{ type: '', price: 0 }]; | ||
|
|
There was a problem hiding this comment.
Perhaps this variable is better named something like pizzaPrices, since you still have to calculate the total prices later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.