Last iteration not done #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlande
reviewed
Oct 4, 2017
| // for(let i = 0; i > lift.floor ;) | ||
|
|
||
| class Person { | ||
| constructor(name, originFloor, destFloor) |
There was a problem hiding this comment.
you are missing the curly braces to open the constructor block {
and close it latet }
mlande
reviewed
Oct 4, 2017
|
|
||
| } | ||
|
|
||
| tom = new Person; |
There was a problem hiding this comment.
These last two lines could probably go in your index.js file, so you can asynchronously call index.js with node
|
The logic seems good, but the idea is to call the class on the index.js file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.