Skip to content

Create mahan.json#33535

Closed
baseri2007 wants to merge 1 commit intois-a-dev:mainfrom
baseri2007:main
Closed

Create mahan.json#33535
baseri2007 wants to merge 1 commit intois-a-dev:mainfrom
baseri2007:main

Conversation

@baseri2007
Copy link

@baseri2007 baseri2007 commented Mar 2, 2026

Requirements

  • I agree to the Terms of Service.
  • My file is following the domain structure.
  • My website is reachable and completed.
  • My website is software development related.
  • My website is not for commercial use.
  • I have provided contact information in the owner key.
  • I have provided a preview of my website below.

Website Preview

@baseri2007 baseri2007 requested a review from a team as a code owner March 2, 2026 14:15
@is-a-dev-reviewbot
Copy link

Hi there! 👋

You've successfully made a pull request! Here are some steps to do while waiting for a maintainer to review the pull request:

  1. Check if the checks have failed or passed. You should see the status at the bottom of the pull request or an icon next to the commit ID.
  2. Check if the filename, file format, and records are valid. If you don't know if it's valid, please read this part of the documentation and use a JSON validator/formatter, like jsonlint. Make sure that the file is in the domains directory and not somewhere else in the repository.
  3. Please make sure that you've filled out the pull request template. It is generally not a good idea to overwrite the pull request template with something else unless you know what you are doing. Make sure to add either a publicly available preview of your website or a screenshot of it.
  4. Please wait patiently. Pull requests may take between a couple hours to 3 days. All of the maintainer team are volunteers and try to review the pull requests in their spare time. If you want a chance of getting your pull request merged faster then send your pull request number once in the #pull-requests channel in our Discord server and wait patiently.
  5. Please note that mentioning maintainers in pull requests without it being reviewed could lead to you getting marked as "low priority"; this also applies to pinging the maintainers in the Discord server or messaging the maintainers in private to review the pull request.

Comment on lines +1 to +8
{
"owner": {
"username": "baseri2007"
},
"records": {
"A": "38.244.201.124"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improper file setup, A records should be in an array.

@DEV-DIBSTER DEV-DIBSTER added reason: invalid file Your file is invalid or improper. reason: incomplete pr Your PR template is not complete. (e.g. missing the requirements form, missing website preview) labels Mar 3, 2026
@DEV-DIBSTER DEV-DIBSTER closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reason: incomplete pr Your PR template is not complete. (e.g. missing the requirements form, missing website preview) reason: invalid file Your file is invalid or improper.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants