Skip to content

Conversation

@ninjaguardian
Copy link
Contributor

Some neoforge mods choose to subscribe to InputEvent.Key to handle input detection, which the current system does not support. I added a keybind for the radial menu so that, when pressed, it will close the screen (some mods check if the screen is null) and send the click input.

The code in this pr supports all Neoforge versions in Controlify.

There seems to be no reason to port this to Fabric, as I've yet to see a Fabric mod look for keyboard inputs directly.

@EchoEllet
Copy link

Some neoforge mods choose to subscribe to InputEvent.Key to handle input detection

NeoForge doc suggests handling via ClientTickEvent.post, so it's probably better to update these mods to do that instead, like this PR.

Mod loaders sometimes introduce breaking changes across versions, so this could risk breaking Controlify for some versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants