Skip to content
This repository was archived by the owner on Feb 27, 2022. It is now read-only.

emit events on resize, restart, quit, quitHard#10

Open
jeffbski wants to merge 4 commits intoisaacs:masterfrom
jeffbski:emitEvents
Open

emit events on resize, restart, quit, quitHard#10
jeffbski wants to merge 4 commits intoisaacs:masterfrom
jeffbski:emitEvents

Conversation

@jeffbski
Copy link
Contributor

In order for other cleanup work to be done, fire events
on the tick prior to performing the work.

Return emitter from clusterMaster constructor.

Also provide getter clusterMaster.emitter() which returns the
same emitter.

Emit events when clusterMaster methods (resize, restart, quit,
or quitHard) are invoked.

The event is emitted to allow additional cleanup in your code
on the tick prior to the method being invoked.

// listen to events to additional cleanup or shutdown
clusterMaster.emitter()
  .on('resize', function (clusterSize) { })
  .on('restart', function () { })
  .on('quit', function () { })
  .on('quitHard', function () { });

Also make sure repl commands and signal listeners do the same.

Add quitHard to repl since it was missing.

Return emitter from clusterMaster constructor.

Also provide getter clusterMaster.emitter() which returns the
same emitter.

Emit events when clusterMaster methods (resize, restart, quit,
or quitHard) are invoked.

The event is emitted to allow additional cleanup in your code
on the tick prior to the method being invoked.

```javascript
// listen to events to additional cleanup or shutdown
clusterMaster.emitter()
  .on('resize', function (clusterSize) { })
  .on('restart', function () { })
  .on('quit', function () { })
  .on('quitHard', function () { });
```
should not call cb in case of error
the restart cb is only called on success
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant