This repository was archived by the owner on Feb 27, 2022. It is now read-only.
Add remove(), entry(), insertBefore(), insertAfter()#6
Open
OJezu wants to merge 2 commits intoisaacs:masterfrom
Open
Add remove(), entry(), insertBefore(), insertAfter()#6OJezu wants to merge 2 commits intoisaacs:masterfrom
OJezu wants to merge 2 commits intoisaacs:masterfrom
Conversation
added 2 commits
January 22, 2014 17:01
Changed push() and unshift(), so that they return a reference that can be later given to the functions above, in order to insert/remove elements into the middle of the list. Added benchmark timing removing entries in random order. TODO: update the documentation and add test for random inserts
Also try adjust to original semi-colon style Closes isaacs#5
Author
|
I just popped by to check if this was merged yet, and found that Travis thinks it is broken. It didn't pass tests because of problems with npm: https://travis-ci.org/isaacs/fast-list/jobs/17475088 Please rerun the test in Travis (as far as I can tell, I can't do that myself). |
|
Would love to have this feature merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion see #5.
Had to create new Pull Request instead of converting #5, since GitHub won't allow the latter via GUI. 😒
Updated readme and finished benchmarks.