Skip to content

Conversation

@brody4hire
Copy link

@brody4hire brody4hire commented May 10, 2019

  • Improve description on built-in stat constructor check
  • Add async fs stats constructor test
  • statSync uid & gid test fixes
    • fix test description
    • remove duplicated Stats constructor check
  • Add async test of stat uid & gid - now skipped on "win32" platform for Travis CI to pass

Open questions:

  • I noticed that the async stat call gives us different uid & gid values from the statSync call (I removed check of actual values due to differences between my mac and Travis CI). I am not sure if this is relevant or not?
  • async stat call does not seem to give us Truthy uid or gid values on Windows ("win32" platform), any explanation?
  • I am not sure if I skipped the async test of uid & gid the right way or not? (some candid feedback is requested)

Christopher J. Brody added 3 commits May 10, 2019 12:54
@brody4hire brody4hire force-pushed the some-stat-test-updates branch from 0aa1e20 to 96308ae Compare May 10, 2019 17:33
(skipped on "win32" platform)
@brody4hire brody4hire force-pushed the some-stat-test-updates branch from 18cdde3 to bff7fd1 Compare May 10, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant