Skip to content

fix: use undefined instead of null for options #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsanders11 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use undefined instead of null for options #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions graceful-fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function patch (fs) {
fs.readFile = readFile
function readFile (path, options, cb) {
if (typeof options === 'function')
cb = options, options = null
cb = options, options = undefined

return go$readFile(path, options, cb)

Expand All @@ -130,7 +130,7 @@ function patch (fs) {
fs.writeFile = writeFile
function writeFile (path, data, options, cb) {
if (typeof options === 'function')
cb = options, options = null
cb = options, options = undefined

return go$writeFile(path, data, options, cb)

Expand All @@ -151,7 +151,7 @@ function patch (fs) {
fs.appendFile = appendFile
function appendFile (path, data, options, cb) {
if (typeof options === 'function')
cb = options, options = null
cb = options, options = undefined

return go$appendFile(path, data, options, cb)

Expand Down Expand Up @@ -194,7 +194,7 @@ function patch (fs) {
var noReaddirOptionVersions = /^v[0-5]\./
function readdir (path, options, cb) {
if (typeof options === 'function')
cb = options, options = null
cb = options, options = undefined

var go$readdir = noReaddirOptionVersions.test(process.version)
? function go$readdir (path, options, cb, startTime) {
Expand Down