Add SYCL support for t/geometry/t/pipelines kernels, Transform ops, and NNS CPU fallback#7443
Draft
Add SYCL support for t/geometry/t/pipelines kernels, Transform ops, and NNS CPU fallback#7443
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
… Registration, RGBDOdometry, TransformationConverter Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
…L declaration Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add equivalent SYCL kernels for existing CUDA kernels
Add SYCL kernels for t/pipelines: Feature, FillInLinearSystem, Registration, RGBDOdometry, TransformationConverter
Feb 20, 2026
… to SYCL kernel files Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
Copilot
AI
changed the title
Add SYCL kernels for t/pipelines: Feature, FillInLinearSystem, Registration, RGBDOdometry, TransformationConverter
Add SYCL kernels for t/pipelines/kernel (Feature, FillInLinearSystem, Registration, RGBDOdometry, TransformationConverter)
Feb 23, 2026
…e coverage Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
Copilot
AI
changed the title
Add SYCL kernels for t/pipelines/kernel (Feature, FillInLinearSystem, Registration, RGBDOdometry, TransformationConverter)
Add SYCL kernels for t/pipelines (Feature, FillInLinearSystem, Registration, RGBDOdometry, TransformationConverter) and enable SYCL test coverage
Mar 13, 2026
…ead of plain global atomics Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
Copilot
AI
changed the title
Add SYCL kernels for t/pipelines (Feature, FillInLinearSystem, Registration, RGBDOdometry, TransformationConverter) and enable SYCL test coverage
Optimize SYCL pipeline kernels: group reduction instead of plain global atomics
Mar 13, 2026
Copilot
AI
changed the title
Optimize SYCL pipeline kernels: group reduction instead of plain global atomics
Add SYCL support for NNS-dependent operations via CPU fallback
Mar 14, 2026
Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
…/Open3D into copilot/add-sycl-kernels-for-cuda
43e7713 to
ef3f5a1
Compare
…als, RotatePoints, RotateNormals Co-authored-by: ssheorey <41028320+ssheorey@users.noreply.github.com>
Copilot
AI
changed the title
Add SYCL support for NNS-dependent operations via CPU fallback
Add SYCL support for t/geometry/t/pipelines kernels, Transform ops, and NNS CPU fallback
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port missing CUDA kernels to SYCL and fix all "Unimplemented device" errors for SYCL tensors in the
t/pipelinesandt/geometrysubsystems.Type
Motivation and Context
SYCL:0devices hitutility::LogError("Unimplemented device")in several hot paths:Transform{Points,Normals}/Rotate{Points,Normals}— no SYCL dispatch inTransform.cppEstimateNormals,EstimateColorGradients,RemoveRadiusOutliers,RemoveStatisticalOutliers,ComputeBoundaryPoints—NearestNeighborSearchasserts non-SYCLt/pipelines/kernelfunctions (ComputeFPFHFeature,ComputePosePoint*,FillInLinearSystem,RGBDOdometry,TransformationConverter) — no SYCL kernels existedChecklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
New SYCL pipeline kernels (
t/pipelines/kernel/)Five new
*SYCL.cppfiles implement SYCL equivalents of every CUDA kernel:FeatureSYCL.cppComputeFPFHFeatureSYCLFillInLinearSystemSYCL.cppFillInRigidAlignmentTermSYCL,FillInSLACAlignmentTermSYCL,FillInSLACRegularizerTermSYCLRegistrationSYCL.cppComputePosePointToPointSYCL,ComputePosePointToPlaneSYCL,ComputeColoredICPResidualAndGradientSYCL,ComputePointToPlaneDistancesSYCLRGBDOdometrySYCL.cppTransformationConverterSYCL.cppKernels use
sycl::nd_range+sycl::reduce_over_groupfor reduction paths (matching CUDA'scub::BlockReduce) instead of plain global atomics, andsycl::local_accessorfor shared local memory.New SYCL geometry kernel (
t/geometry/kernel/)TransformSYCL.cpp— SYCL implementations ofTransformPoints,TransformNormals,RotatePoints,RotateNormalsviasycl::queue::parallel_for. Reuses the existingTransformImpl.hper-element kernels, guarded by a newOPEN3D_SKIP_TRANSFORM_MAINmacro (mirrorsOPEN3D_SKIP_FPFH_MAINinFeatureImpl.h) to avoid duplicate symbol errors.Transform.cppandTransform.hupdated withIsSYCL()dispatch branches.NNS CPU fallback for SYCL devices (
t/geometry/PointCloud.cpp,t/pipelines/registration/)NearestNeighborSearchexplicitly rejects SYCL tensors. Every NNS call site now transparently redirects to CPU whendevice.IsSYCL():Affected:
EstimateNormals(Hybrid/KNN/Radius),EstimateColorGradients(Hybrid/KNN/Radius),RemoveRadiusOutliers,RemoveStatisticalOutliers,ComputeBoundaryPoints,ComputeFPFHFeature,CorrespondencesFromFeatures,EvaluateRegistration,MultiScaleICP,GetInformationMatrix.Test coverage
All
t/pipelinestests (Registration,Feature,TransformationEstimation,RGBDOdometry,TransformationConverter, SLAC) updated to usePermuteDevicesWithSYCLso SYCL:0 is exercised in CI.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.