Add read flags: include info, include data, objects only#37
Merged
Add read flags: include info, include data, objects only#37
Conversation
madebr
reviewed
Oct 24, 2025
madebr
approved these changes
Oct 24, 2025
Contributor
madebr
left a comment
There was a problem hiding this comment.
Forwarding the thorough review to @itsmattkc
Merged
Contributor
|
@foxtacles --- a/extensions/src/siloader.cpp
+++ b/extensions/src/siloader.cpp
@@ -242,10 +242,10 @@ bool SiLoader::LoadFile(const char* p_file)
MxString path = MxString(MxOmni::GetHD()) + p_file;
path.MapPathToFilesystem();
- if (si.Read(path.GetData(), si::Interleaf::ObjectsOnly | si::Interleaf::NoInfo) != si::Interleaf::ERROR_SUCCESS) {
+ if (si.Read(path.GetData(), si::Interleaf::ObjectsOnly) != si::Interleaf::ERROR_SUCCESS) {
path = MxString(MxOmni::GetCD()) + p_file;
path.MapPathToFilesystem();
- if (si.Read(path.GetData(), si::Interleaf::ObjectsOnly | si::Interleaf::NoInfo) !=
+ if (si.Read(path.GetData(), si::Interleaf::ObjectsOnly) !=
si::Interleaf::ERROR_SUCCESS) {
SDL_Log("Could not parse SI file %s", p_file);
return false; |
Member
Author
Yep! |
Contributor
|
This needs a rebase on top of current master for isle-portable :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds flags to the
Readfunctions, in order to allow parsing meta information from a SI file:IncludeData: reads data of objectsIncludeInfo: writes to theinfoobjectObjectsOnly: reads objects only, excludes everything elseReading
ISLE.SIIncludeData+IncludeInfo(default): 314MBIncludeInfo: 17MBObjectsOnly: 5.6MB(3.2MB was the test program itself in memory)
Close #34