Skip to content

Add <algorithm> include for std::{min,max}#40

Merged
foxtacles merged 1 commit intoisledecomp:masterfrom
madebr:algorithm-for-std-min-max
Nov 22, 2025
Merged

Add <algorithm> include for std::{min,max}#40
foxtacles merged 1 commit intoisledecomp:masterfrom
madebr:algorithm-for-std-min-max

Conversation

@madebr
Copy link
Contributor

@madebr madebr commented Nov 22, 2025

lib/file.cpp uses std::min, which is provided by the <algorithm> header.

This should fix the following errors (untested):

 D:\a\isle-portable\isle-portable\build\3rdparty\libweaver-src\lib\file.cpp(285): error C2589: '(': illegal token on right side of '::'
D:\a\isle-portable\isle-portable\build\3rdparty\libweaver-src\lib\file.cpp(285): error C2059: syntax error: ')'
D:\a\isle-portable\isle-portable\build\3rdparty\libweaver-src\lib\file.cpp(288): error C2589: '(': illegal token on right side of '::'
D:\a\isle-portable\isle-portable\build\3rdparty\libweaver-src\lib\file.cpp(288): error C2059: syntax error: ')'
D:\a\isle-portable\isle-portable\build\3rdparty\libweaver-src\lib\file.cpp(303): error C2589: '(': illegal token on right side of '::'
D:\a\isle-portable\isle-portable\build\3rdparty\libweaver-src\lib\file.cpp(303): error C2059: syntax error: ')'

See this ci run

@madebr madebr requested a review from foxtacles November 22, 2025 18:35
@foxtacles foxtacles merged commit afd4933 into isledecomp:master Nov 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants