Update install.sh: automatically set default external endpoint and interface#7
Open
ceyes wants to merge 1 commit intoisystem-io:masterfrom
Open
Update install.sh: automatically set default external endpoint and interface#7ceyes wants to merge 1 commit intoisystem-io:masterfrom
ceyes wants to merge 1 commit intoisystem-io:masterfrom
Conversation
shrinidhi111
approved these changes
Apr 1, 2020
shrinidhi111
left a comment
shrinidhi111
left a comment
There was a problem hiding this comment.
I was just working on adding these two additional features to have an option to automatically default interface and IP.
Tested this and works as expected. I recommend these changes as they are simply addition but saves a lot of debugging for first timers.
|
@alexey-chernyavskiy would you please merge this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch will make the install.sh to automatically get the instance's external IP address and default network interface, then set as fallback value so user can skip them. Tested pass on my ec2 with and without these parameters.