Conversation
paulotex
requested review from
SimonPinches,
olivhoenen and
prasad-sawantdesai
as code owners
| MACOSX_DEPLOYMENT_TARGET = "14.0" | ||
| AL_BACKEND_HDF5 = { env = "AL_BACKEND_HDF5", default = "ON" } | ||
| AL_BACKEND_UDA = { env = "AL_BACKEND_UDA", default = "ON" } | ||
| AL_BACKEND_MDSPLUS = { env = "AL_BACKEND_MDSPLUS", default = "OFF" } |
There was a problem hiding this comment.
There are MDSplus packages for Macs running on Intel silicon: https://www.mdsplus.org/index.php/Latest_Macintosh_Distributions
Could these easily be dropped in?
There was a problem hiding this comment.
It says that the apple silicon port is not complete, so I left it out for now.
| brew update >&2; | ||
| brew install cmake pkg-config boost hdf5 libomp ninja fmt spdlog libxml2 openssl capnp libmemcached >&2; | ||
| brew install cmake pkg-config boost hdf5 libomp ninja fmt spdlog libxml2 openssl libmemcached >&2; | ||
| git clone -b master https://github.com/capnproto/capnproto.git >&2 && |
There was a problem hiding this comment.
The master branch is not the same as the latest release. Is this what we want to do? What was wrong with the homebrew install? (https://formulae.brew.sh/formula/capnp).
There was a problem hiding this comment.
I was not able to remove the homebrew dependencies from the wheel. The other libs worked fine, but capnp had some deps left over after delocate, that make the wheel fail. I can revisit this again...
There was a problem hiding this comment.
I tried again using capnp from brew, the error I get when trying to delocate is:
ERROR:delocate.libsana:
@rpath/libkj.1.3.0.dylib not found:
Needed by: /private/var/folders/7n/qzhf5d250mdck5bq8wmqy_fh0000gn/T/tmp1x_w1hep/wheel/imas_core.libs/libcapnp.1.3.0.dylib
Search path:
So somehow the brew libs used by capnp could not be delocated properly. There are probably ways to fix this, but compiling capnp from scratch takes one sec, so I went that route.
There was a problem hiding this comment.
Okay, then let's not spend more time on this at the moment.
3 participants
Adding UDA (and capnp) support for macos-arm wheel.