[pull] master from KelvinTegelaar:master #101
Open
+7,211
−238,301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the GitHub Actions workflow to build the CIPPCore PowerShell module using ModuleBuilder, including module caching and build steps. Modified CIPPCore.psm1 to support both source and built module loading. Added build.psd1 configuration for ModuleBuilder. Updated CippCore.psd1 to support the new build process.
Added several JSON and CSV files, as well as a DLL, to the CopyPaths array in build.psd1 to ensure they are included in the build output. Updated CippCore.psd1 binary, likely reflecting related metadata changes.
Moved static data files from Public/ to lib/data/ and updated all script references to use the new path via the module base directory. Simplified build.psd1 CopyPaths to include the entire lib directory. Added new output files under Output/CIPPCore/ including the module manifest, module file, and required data files.
Replaces Write-AlertMessage with Write-LogMessage for better error reporting, including severity, API context, and detailed exception data.
Adds -ErrorAction SilentlyContinue and -Compress to ConvertTo-Json and ConvertFrom-Json calls for repository permissions. This change prevents errors from interrupting execution if JSON conversion fails and ensures more robust handling of permission data.
Added null-coalescing operators to ensure $Users and $ServicePrincipals are always arrays, preventing potential errors when responses or cached data are missing or null. Also added -ErrorAction SilentlyContinue to ConvertFrom-Json calls for more robust error handling.
Updated the logic to check for cached GitHub release notes to match the current major.minor version series using semantic versioning, instead of only matching the full release tag. This ensures that release notes are refreshed only when the major.minor version changes, improving cache efficiency.
Refactored location processing in New-CIPPCATemplate to reduce redundant API calls and ensure unique location info. Enhanced Set-CIPPCAPolicyServiceException with clearer logic, improved string handling, and added more informative logging. Minor bug fixes and code style improvements in Invoke-ExecCAServiceExclusion and New-CIPPCAPolicy for robustness.
Dev to hotfix
Updated the error handling in Get-CIPPAlertTERRL.ps1 to use Write-LogMessage instead of Write-AlertMessage, adding more detailed logging with severity, API, and exception data.
Fix: Fix RecipientAddress display in quarantine request alert
Extended the policy deviation objects in Get-CIPPDrift to include Reason and lastChangedByUser fields when available from existing drift states. This provides more context about policy changes and their origins.
Updated policy template matching logic to include the Source (TenantFilter) property, ensuring templates are matched and updated per tenant. Also standardized usage of policy ID and display name variables for consistency and correctness.
Introduces 'source' and 'isSynced' properties to template objects across multiple modules for improved traceability and synchronization status. Updates Import-CommunityTemplate and related functions to handle and propagate the new properties.
Updated the NameOnly parameter handling to filter out partitioned RowKeys and apply TenantFilter matching on RowKey when NameOnly is present. This improves the accuracy of backup name retrieval and ensures correct filtering based on tenant.
Updated the tenant filter condition to exclude 'AllTenants' from being treated as a specific tenant filter. This ensures that backups are not incorrectly filtered when 'AllTenants' is specified.
Updated Invoke-ExecListBackup to extract and include TenantFilter from RowKey when NameOnly is specified. Also excluded 'OriginalEntityId' from the listed properties.
Dev to hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )