Fix issue with multiple containment relations being tested on an entity. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a DFS strategy for testing multiple types of relationships.
garethj2
approved these changes
Aug 4, 2025
Contributor
garethj2
left a comment
garethj2
left a comment
There was a problem hiding this comment.
Looks goo to me. I added a unit test.
@hecsalazarf please take a look.
Contributor
|
As well as adding a unit test for the Rust code, I've also added to the TypeScript haystack-core library. I wanted to double check this issue doesn't exist there (which it doesn't). |
hecsalazarf
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a DFS strategy for testing multiple types of relationships.