Formalizes fixes for #19 by dropping configurations and defaulting the keep-listening behavior #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 83.76% 83.63% -0.13%
==========================================
Files 10 10
Lines 659 611 -48
Branches 81 76 -5
==========================================
- Hits 552 511 -41
+ Misses 73 67 -6
+ Partials 34 33 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are all related to #19:
setUsePreDrawOverGlobalLayoutEnabled. Using theOnPreDrawListenerover theOnGlobalLayoutListenerdid not solve the underlying issue; it just delayed the start of the sizing process under normal cases.setAttemptLastDitchPostForLayoutResolutionFailure. The last-ditch post on receiving invalid sizes caused more harm than good.setKeepListeningForDrawUntilValidSizeDiscovered. The continued listening for a valid size was the ultimate fix and has become the default behavior moving forward.