Conversation
|
This pull request removes Neovim-specific code and completely disables the plugin if the editor is Neovim. This makes the remaining code easier to maintain. Neovim users have two options:
|
There was a problem hiding this comment.
Pull request overview
Removes Neovim support paths from Vim-R by short-circuiting runtime in Neovim and simplifying job/terminal/float handling to Vim-only APIs.
Changes:
- Add early
has("nvim")guards to stop loading filetype plugins/syntax/ftdetect under Neovim. - Remove Neovim-specific job/terminal/buffer/float implementations and keep Vim’s
job_start(),popup_*, and:terminalcode paths. - Update documentation and Windows integration code to remove Neovim-specific notes/branches.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| syntax/rout.vim | Skip loading Rout syntax under Neovim. |
| syntax/rdoc.vim | Skip loading R doc syntax under Neovim. |
| syntax/rbrowser.vim | Skip loading object browser syntax under Neovim. |
| ftplugin/rrst_vimr.vim | Skip rrst ftplugin under Neovim; remove g:has_Rnvim gate. |
| ftplugin/rnoweb_vimr.vim | Skip rnoweb ftplugin under Neovim; remove g:has_Rnvim gate. |
| ftplugin/rmd_vimr.vim | Skip rmd ftplugin under Neovim; remove g:has_Rnvim gate. |
| ftplugin/rhelp_vimr.vim | Skip rhelp ftplugin under Neovim; remove g:has_Rnvim gate. |
| ftplugin/rdoc.vim | Skip rdoc ftplugin under Neovim; remove g:has_Rnvim gate. |
| ftplugin/rbrowser.vim | Skip rbrowser ftplugin under Neovim; remove Neovim buffer-update branch. |
| ftplugin/r_vimr.vim | Skip r ftplugin under Neovim; remove Neovim jobstart branch. |
| ftplugin/quarto_vimr.vim | Skip quarto ftplugin under Neovim; remove g:has_Rnvim gate. |
| ftdetect/r.vim | Skip filetype detection under Neovim. |
| doc/Vim-R.txt | Remove Neovim-specific documentation and update notes accordingly. |
| README.md | Remove Neovim-related “See also” references. |
| R/windows.vim | Remove Neovim-specific Windows start branch; use Vim shell invocation. |
| R/vimcom/src/apps/vimrserver.c | Remove Neovim window-title handling; update messaging to Vim. |
| R/start_server.vim | Remove Neovim job callback shapes; keep Vim job callbacks only. |
| R/start_r.vim | Remove Neovim buffer/term/job branches; keep Vim-only code paths. |
| R/rstudio.vim | Remove Neovim jobstart branch; keep Vim job callbacks. |
| R/rnw_fun.vim | Remove Neovim-specific commented attempt in SyncTeX backward. |
| R/pdf_zathura.vim | Remove Neovim Zathura launching; keep Vim job implementation. |
| R/pdf_okular.vim | Remove Neovim Okular launching; keep Vim job implementation. |
| R/pdf_evince.vim | Update Evince comment wording from Neovim to Vim. |
| R/nvimrcom.vim | Remove Neovim-only job/channel glue (file deleted). |
| R/nvimbuffer.vim | Remove Neovim-buffer R console implementation (file deleted). |
| R/functions.vim | Skip functions file under Neovim; remove Neovim buffer syntax refresh. |
| R/extern_term.vim | Remove Neovim env var and jobstart branches; keep Vim StartJob usage. |
| R/complete.vim | Remove Neovim floating window implementation; use Vim popups only. |
| R/common_global.vim | Make plugin immediately finish on Neovim; remove Neovim notify/float code and Neovim version checks. |
| R/common_buffer.vim | Remove g:has_Rnvim early return after sourcing common_global.vim. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Do you still use Vim and |
Hi, I support this move for the sake of maintainability of |
No description provided.