Open
Conversation
added 8 commits
August 22, 2018 14:27
yousifS
reviewed
Sep 22, 2018
| void CheckPlayerMove(){ | ||
| //MOVEMENT CHECKS / TO | ||
| Checker checkerToMove = SelectChecker(fromX, fromY); | ||
| if (!validInput.Contains(toX) || !validInput.Contains(toY)) // CHECKS IF DESTINATION IS OUT OF BOUNDS |
There was a problem hiding this comment.
you call SelectChecker(toX, toY) multiple times, could probably have made a targetChecker variable to hold that and used it.
Checker targetChecker = SelectChecker(toX,toY);
Seems like you are relying on the grid[toX,toY] to tell if the destination is empty square.
You could use the targetChecker to check, and that way the grid is just for drawing
bool emptyTargetSpace = targetChecker == null;
bool isEnemyTarget = targetChecker == null ? false : targetChecker.color != checkerToMove.color;
yousifS
reviewed
Sep 22, 2018
| public int[] position = new int[2]; | ||
| public bool isWhite {get;private set;} | ||
|
|
||
| public int xPos {get;set;} |
There was a problem hiding this comment.
I dont see you making use or updating xPos and yPos.
yousifS
reviewed
Sep 22, 2018
| int openCircleId = int.Parse(" 25CE", System.Globalization.NumberStyles.HexNumber); | ||
| string openCircle = char.ConvertFromUtf32(openCircleId); | ||
| int closedCircleId = int.Parse(" 25C9", System.Globalization.NumberStyles.HexNumber); | ||
| string closedCircle = char.ConvertFromUtf32(closedCircleId); |
There was a problem hiding this comment.
it does not look like you are using openCircle or closedCircle anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.