Removed reference to log4net #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 17, 2015 14:51
Abstracted the logger interface so different log libraries can be used. Implemented a default logger that print out using Diagnostic.Trace Implemented ILogger interface on JwtAuthForWebAPI .SampleSite
Abstracted the logger interface so different log libraries can be used. Implemented a default logger that print out using Diagnostic.Trace Implemented ILogger interface on JwtAuthForWebAPI .SampleSite
Owner
|
@lineker so sorry... I just saw this PR. Not sure what happened to the initial email from Github... regardless, do you still need this merged? |
|
I'd also like to see this merged. We use NLog in most of our web services so avoiding a log4net reference would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I removed the strong reference to the log4net library and added an interface so, it can be implemented with any library.
Let me know if you have any questions.