Update of compMRS_DPproc and subfunctions#12
Open
tpkle wants to merge 9 commits intojamienear:mainfrom
Open
Conversation
Output the number of points to be leftshifted to fix the 1st order phase distortion.
Update compMRS_parseBrukerFormat.m to properly read refscans in method file. Update compMRS_loadspecBruker.m to get the group delay in all cases (either acqp or acqus files, and from parameter GRPDLY or ACQ_RxFilterInfo). We no longer perform leftshift in compMRS_loadspecBruker; this will be done in compMRS_DPproc.m
compMRS_DPload is modified to make it compatible with DP36 (no separate refscan, only automatic refscan). Update of compMRS_DPproc. Most DPs can be processed. There are still issues with SPECIAL acquisitions on Bruker systems. The first-order phase correction in case of a non-integer of left-shifted points still has to be checked. New compMRS_runDPproc_onAllDP.m script to process all DPs at once.
All datasets can be processed now (there are still some phasing issues), except DP22 and DP23 (different sequence, and how data are arranged).
There are still few phasing issues. Most DPs can be phased using op_autophase at the end, but for some datasets (DP 06, 07, 08, 36), the result is better without autophase. There are several issues with DP17, and the SNR seems very poor.
Contributor
|
FAO @DianaaRotaru |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most DPs can be processed now with some issues with the phase. For some DPs, there are some subjects where the output spectrum looks really bad. We should check whether it is a data or processing issue.