feat: respect default ID type from db adapter #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! First of all, thank you for developing this library.
When using this library with SQLite, I found a issue where the generated OpenAPI schema specifies
idas a string when it should be number. After digging into Payload's source code, it seems that theidfield type should be determined by the DB adapter by default, e.g.:https://github.com/payloadcms/payload/blob/main/packages/payload/src/bin/generateTypes.ts#L32
This PR updates the relevant calls to
entityToJSONSchemato useconfig.db.defaultIDTypeas the default ID type, which corrects the type ofidfields. I have also added a test case using the sqlite adapter to demonstrate this.Thanks for your time to review this!