Fix cgidata errors #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still many strings that need fixed still.
password was a byte string comparing to a normal string this make sure it stays a normal string instead of a byte string
switched to using `exec(open(file).read())` https://docs.python.org/3.3/whatsnew/3.0.html?highlight=execfile#builtins
… handling occurs. RetryRunner sleeps for 15 minutes in _snooze. When the TERM signal comes in, it interrupts this sleep but then restarts it and allows it to finish before the signal handler gets called. So: If the sleep time is something very short, like 1 second, the signal handling happens reasonably promptly, and the process will exit as expected. If the sleep time is something medium length, like 20 seconds, then we might have to wait up to 20 seconds (depending on how far into the sleep we were) before the signal handler is called. If the sleep time exceeds 90 seconds, as it did prior to this change, then we will run into systemd's own 90 second timeout, at which point it will switch from TERM to KILL to circumvent this problem. It's normal in mailman for a qrunner process to have a sleep time of 1 second, so we might as well do the same thing with RetryRunner.
…L/mailman2:HB-7996 to hb_main * commit '90233cd409270c259caf17cb4ee29e8fe4e532c1': HB-7996: Sleep 1s instead of 15m in RetryRunner to ensure TERM signal handling occurs.
- address some attribute issues with MailList.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.