Skip to content

Conversation

@pratham12102004
Copy link

Description

This Pull Request implements the homepage navigation link for the Jargons.dev logo in the header. This follows standard web conventions, allowing users to return to the root page from anywhere on the site, thereby improving general user experiencefix(logo): Add homepage link to the Logo component #200

Related Issue

Fixes #200

Screenshots/Screencasts

before and after image of code is uploded

Notes to Reviewer

The required link was implemented in src/components/navbar.astro. I wrapped the existing component with an anchor tag () set to the site root (href="/"). No new npm
image (1)

@vercel
Copy link

vercel bot commented Sep 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
jargons-dev Ready Ready Preview Comment Sep 28, 2025 4:16pm

@pratham12102004
Copy link
Author

hey please accept my merge request

Copy link
Member

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pratham12102004 ,

Great PR 😀, I can wait to merge this after you make the changes stated in the comment.

It's also currently failing CI due to formatting issue, but that can be fixed easily 😉

Just run the command npm run format and commit the changes and we're good 😁

Let's go!

@pratham12102004
Copy link
Author

@babblebey
The Requested changes has been implemented and pushed
1.The logo component class has been updated to restore the md:h-12 class for proper scaling on large devices.
2,. I have run the project's formatter (npm run format) to ensure all code style issues are resolved and CI checks will pass.
0002
0001

@babblebey
Copy link
Member

Okay @pratham12102004

I think you might have forgotten to push the change 😉

@babblebey babblebey added the stale This PR is no longer worked on label Oct 18, 2025
@babblebey
Copy link
Member

Hi @pratham12102004

It's been a moment you pushed any change here, the PR is now stale, I hope you're well... is there any chance you're able to conclude this soon!?

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This PR is no longer worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Homepage Link to Logo Component

2 participants