-
-
Couldn't load subscription status.
- Fork 43
Update navbar.astro #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update navbar.astro #207
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
hey please accept my merge request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pratham12102004 ,
Great PR 😀, I can wait to merge this after you make the changes stated in the comment.
It's also currently failing CI due to formatting issue, but that can be fixed easily 😉
Just run the command npm run format and commit the changes and we're good 😁
Let's go!
|
@babblebey |
|
Okay @pratham12102004 I think you might have forgotten to push the change 😉 |
|
It's been a moment you pushed any change here, the PR is now stale, I hope you're well... is there any chance you're able to conclude this soon!? 😉 |


Description
This Pull Request implements the homepage navigation link for the Jargons.dev logo in the header. This follows standard web conventions, allowing users to return to the root page from anywhere on the site, thereby improving general user experiencefix(logo): Add homepage link to the Logo component #200
Related Issue
Fixes #200
Screenshots/Screencasts
before and after image of code is uploded
Notes to Reviewer
The required link was implemented in src/components/navbar.astro. I wrapped the existing component with an anchor tag () set to the site root (href="/"). No new npm
