Skip to content

Fix a crash when removing tokens #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeahphil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a crash when removing tokens #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion JSTokenField/JSTokenField.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,10 +373,17 @@ - (BOOL)textField:(UITextField *)textField shouldChangeCharactersInRange:(NSRang
}

NSString *name = [token titleForState:UIControlStateNormal];

// If we don't allow deleting the token, don't even bother letting it highlight
if ([self.delegate tokenField:self shouldRemoveToken:name representedObject:token.representedObject]) {
BOOL shouldHighlight = YES;
if ([self.delegate respondsToSelector:@selector(tokenField:shouldRemoveToken:representedObject:)]) {
shouldHighlight = [self.delegate tokenField:self shouldRemoveToken:name representedObject:token.representedObject];
}

if (shouldHighlight) {
[token becomeFirstResponder];
}

return NO;
}

Expand Down