-
Notifications
You must be signed in to change notification settings - Fork 16
Add optimizer control settings for classical LMM and GLMM #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
FBartos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot put the QML interface into a new common separate qml section called Advanced thats added the bottom of the LMM and GLMM's qml
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
Done! I've extracted the optimizer settings into a new common QML component called |
Co-authored-by: FBartos <38475991+FBartos@users.noreply.github.com>
|
so, this turned to be much more complicated than expected |
This PR adds optimizer control settings to the classical Linear Mixed Models (LMM) and Generalized Linear Mixed Models (GLMM) modules, allowing users to adjust optimizer parameters when models fail to converge.
Changes Made
UI Enhancements
Code Organization
Advanced.qmlcomponent in the common folder containing optimizer settingsBackend Implementation
.mmCreateOptimizerControl()function to handle optimizer-specific parameters according to each optimizer's documentation.mixedInterceptML()for intercept-only modelsafex::mixed()calls for full modelslmer/glmerfunctions viaoptCtrlparameterError Message Improvements
Testing
Scope
This enhancement is only available for classical models (LMM and GLMM). Bayesian models continue to use their existing MCMC control settings and are unaffected by these changes.
Motivation
Complex mixed models often encounter convergence issues that can be resolved by adjusting optimizer settings. This was previously impossible in JASP, forcing users to abandon analyses or switch to other tools. These new controls provide the flexibility needed to handle challenging models while maintaining JASP's user-friendly interface.
Fixes #252.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.