Skip to content

Conversation

@AbHiNAv-N260
Copy link

No description provided.

@jaspal007
Copy link
Owner

jaspal007 commented Sep 25, 2023

Nice work @abhinavn2206146 ! 🎊
I really appreciate your thought process you applied for filtering the data. 😎

Issues with the commit

Use of Json file

Now what I really wanted you to do was do the processing on the data from the json file itself.
Sure, the data for this assignment was too short so hard coding that data in your user defined class was quite a smart move!
Now lets imagine a situation where this data is in 100s or even 1000s lines of code. To make things even worse, what if the data is DYNAMIC , changes all the time...
You see in these cases hard coding the data is not going to work for too long.
So try to fetch data from json file itself using different properties of maps and keys and values.

Making the app responsive

As I mentioned, try not to hard code sizes of widgets rather make it flexible according to the device.
Use different simulators or physical devices to build the responsiveness.
Use media query, screenUtil packages to achieve the goal

@jaspal007
Copy link
Owner

@abhinavn2206146 you have declared and defined a variable isLandscape but haven't used it.
try to build the application around the orientation of the device and resize widgets or make them scrollable as per the orientation to avoid overflow errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants