Skip to content

Conversation

@Arnav1a
Copy link

@Arnav1a Arnav1a commented Sep 24, 2023

No description provided.

@jaspal007
Copy link
Owner

Congrats @Arnav1a on completing your first task! 🎊
Though before this branch can be merged with the main, there are some issues, that needs to be addressed.

Issue of the commit

Using json file

  • Since I just want you all to learn the basics of searching and sorting so how you do it, what data you use doesn't matter at this stage.
  • But as we know being a contributor to a project is a serious responsibility!
  • On senior levels you need to work around the data provided by the source, even if its hard to comprehend! 😿
    • We can decide which data to fetch and to use but not under any circumstances can we modify the source data
    • Try to work around the sample.json provided.

Assets not loading properly

image

try to find the error in your code that is causing this unexpected error!

  • do note that the error can not only creep in the main.dart but also other files of the projects
  • Reference

Implementing the filtering criteria

Re evaluate your code and try implementing the different filters that is going to re arrange the items of the list according to the criteria.

README.md

  • Go through the README.md file of the main branch and update the README.md of your flutter project in that format.

@jaspal007
Copy link
Owner

@Arnav1a props to you on completing the assignment. 👏
Creating application doesn't just means only having an interface to show the data. It is also necessary to provide the best possible use experience to our users.
Try to give some time on making your application a bit expressive and more user friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants