Default 4 syllable keyword HelloJasper works much better for new users#493
Open
GeoBeBee wants to merge 5 commits intojasperproject:jasper-devfrom
Open
Default 4 syllable keyword HelloJasper works much better for new users#493GeoBeBee wants to merge 5 commits intojasperproject:jasper-devfrom
GeoBeBee wants to merge 5 commits intojasperproject:jasper-devfrom
Conversation
Author
|
The problem with the weather might be fixed by #483, another day...;-). |
|
Changes Unknown when pulling e579cc6 on GeoBeBee:jasper-dev into * on jasperproject:jasper-dev*. |
This was referenced Apr 24, 2016
Merged
Author
|
As far as I understand it I've done what I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first ever contribution to open source, so please be kind? - I have lots of ideas... ;-)
What: The change is very simple: the default keyword in application.py is changed from "Jasper" to "HelloJasper" which I have found is far more reliable.
Why: I have found lots of people struggling with Jasper not recognising the keyword, and I guess some may just give up on it, which would be a pity after they got so far.
I have created the following and posted it in various places in the hope that people will understand the use of the keyword:
https://github.com/GeoBeBee/mySystem/blob/master/Jasper_keywords.txt
As a next change I might update jasper-client/client/populate.py to set the keyword..?
Keeping this forking, committing, pushing, branching simple to start with... ;-p
Thanks, Geoff