-
Notifications
You must be signed in to change notification settings - Fork 71
JERSEY-2429: JDK8 support #5
Conversation
|
Jersey - JAX-RS Reference Implementation » jersey-1.x #6 UNSTABLE |
|
I don't see how the commit can be causing these failures. It sounds like a bug in the unit tests themselves (are they stable?) Please review and see if you spot something I missed. |
|
@mpotociar Why did you close this pull request without merging it and without an explanation? |
|
retest this please |
|
@shamoh Is the last comment directed at me? What do you want me to retest exactly? |
|
@shamoh Ah. Very cool :) Thanks for the clarification. |
|
test this please |
|
@cowwoc The last request is also to Mr. Jenkins. (Sorry for spam he ignores me. :-( ) |
|
@shamoh This doesn't seem to be working. The job you linked to at cloudbees is for Jersey 2.x, not 1.x. Perhaps you need to create a separate job for Jersey 1.x? |
|
@cowwoc You are right. |
|
Any updates? I know upgrading to 2.x is preferred. However, if it's possible to run existing Jersey 1 apps on Java 8, it will be great pleasure for us. |
|
Please describe in the commit message what has been done in a bit more detail. |
|
@mpotociar Borrowing from the original commit message: Is that enough? |
|
yes, thanks |
Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com> Change-Id: I2a366e9975f7a9853f82aa4bb428fab37cbfe02d
- Allow raw ManagedBeans as JAX-RS components Change-Id: I8a14287ee7aad18f0362b80d5a229830767e436a Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: I6a7824157836f479cc69e3c33e0d9c67fc583069 Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: I3d3cc2085d95e09bc229011088528c8edec2c830 Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
|
Any updates? |
JAX-RS components Change-Id: Iee5a308aa1c6f512c1eb805289a916bb93b1c72a Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: I80fe1493491c6619727afe5edd8c96effb839da6 Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: Ifaabc974ba8bfa2a8b4aa8e99a0048a783a70bff Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
|
Any updates? I am anxious to use this support. |
|
Would be great if this got merged and released |
|
@cowwoc Can you, please, create a new pull request (or edit this one if it's possible) and target the change to branch 1.18.x and not 1.18.1? I'll merge it then and cherry-pick it to master. Thanks. |
|
Hooray! |
|
Good news 😃 |
|
@mgajdos Try the updated PR. I couldn't test it locally because I'm blocked on JERSEY-2430 and installing JDK7 on this machine is too much of a headache. |
|
Gili, you're still trying to merge the change into 1.18.1 branch, see: The target branch should be changed to |
|
Merged new pull request (#13) |
|
Good luck guys! I hope this helps. |
|
@cowwoc Thank you for your contribution. |
I merged a subset of jersey/jersey@411f767 into Jersey 1.x.
This fix works for me. Please review, test, and merge.
Please note I only merged JDK8-specific changes. I ignored localization and other enhancements, which you might want to also merge.