Skip to content
This repository was archived by the owner on Jan 27, 2021. It is now read-only.

Conversation

@cowwoc
Copy link
Contributor

@cowwoc cowwoc commented Mar 1, 2014

I merged a subset of jersey/jersey@411f767 into Jersey 1.x.

This fix works for me. Please review, test, and merge.

Please note I only merged JDK8-specific changes. I ignored localization and other enhancements, which you might want to also merge.

@buildhive
Copy link

Jersey - JAX-RS Reference Implementation » jersey-1.x #6 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@cowwoc
Copy link
Contributor Author

cowwoc commented Mar 1, 2014

I don't see how the commit can be causing these failures. It sounds like a bug in the unit tests themselves (are they stable?)

Please review and see if you spot something I missed.

@mpotociar mpotociar closed this Mar 21, 2014
@cowwoc
Copy link
Contributor Author

cowwoc commented Mar 21, 2014

@mpotociar Why did you close this pull request without merging it and without an explanation?

@mpotociar mpotociar reopened this Mar 25, 2014
@shamoh
Copy link
Contributor

shamoh commented Apr 7, 2014

retest this please

@cowwoc
Copy link
Contributor Author

cowwoc commented Apr 7, 2014

@shamoh Is the last comment directed at me? What do you want me to retest exactly?

@shamoh
Copy link
Contributor

shamoh commented Apr 8, 2014

@cowwoc No. Excuse it, it is "command" for associated Jenkins CI engine running at cloudbees

@cowwoc
Copy link
Contributor Author

cowwoc commented Apr 8, 2014

@shamoh Ah. Very cool :) Thanks for the clarification.

@shamoh
Copy link
Contributor

shamoh commented Apr 8, 2014

test this please

@shamoh
Copy link
Contributor

shamoh commented Apr 8, 2014

@cowwoc The last request is also to Mr. Jenkins. (Sorry for spam he ignores me. :-( )

@cowwoc
Copy link
Contributor Author

cowwoc commented Apr 8, 2014

@shamoh This doesn't seem to be working. The job you linked to at cloudbees is for Jersey 2.x, not 1.x. Perhaps you need to create a separate job for Jersey 1.x?

@shamoh
Copy link
Contributor

shamoh commented Apr 9, 2014

@cowwoc You are right.

@seratch
Copy link

seratch commented Jul 30, 2014

Any updates? I know upgrading to 2.x is preferred. However, if it's possible to run existing Jersey 1 apps on Java 8, it will be great pleasure for us.

@mpotociar
Copy link
Contributor

Please describe in the commit message what has been done in a bit more detail.

@cowwoc
Copy link
Contributor Author

cowwoc commented Jul 30, 2014

@mpotociar Borrowing from the original commit message:

 - Updated to ASM 5.0
 - Repackaging ASM in core-server and jaxrs-ri

Is that enough?

@mpotociar
Copy link
Contributor

yes, thanks

Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: I2a366e9975f7a9853f82aa4bb428fab37cbfe02d
- Allow raw ManagedBeans as JAX-RS components

Change-Id: I8a14287ee7aad18f0362b80d5a229830767e436a
Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: I6a7824157836f479cc69e3c33e0d9c67fc583069
Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: I3d3cc2085d95e09bc229011088528c8edec2c830
Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
@seratch
Copy link

seratch commented Oct 14, 2014

Any updates?

japod added 3 commits December 1, 2014 11:55
 JAX-RS components

Change-Id: Iee5a308aa1c6f512c1eb805289a916bb93b1c72a
Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: I80fe1493491c6619727afe5edd8c96effb839da6
Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
Change-Id: Ifaabc974ba8bfa2a8b4aa8e99a0048a783a70bff
Signed-off-by: Jakub Podlesak <jakub.podlesak@oracle.com>
@jstockdi
Copy link

jstockdi commented Dec 8, 2014

Any updates? I am anxious to use this support.

@jhaber
Copy link

jhaber commented Jan 8, 2015

Would be great if this got merged and released

@mgajdos mgajdos self-assigned this Jan 28, 2015
@mgajdos
Copy link
Contributor

mgajdos commented Jan 28, 2015

@cowwoc Can you, please, create a new pull request (or edit this one if it's possible) and target the change to branch 1.18.x and not 1.18.1? I'll merge it then and cherry-pick it to master. Thanks.

@jhaber
Copy link

jhaber commented Jan 28, 2015

Hooray!

@seratch
Copy link

seratch commented Jan 28, 2015

Good news 😃

@cowwoc
Copy link
Contributor Author

cowwoc commented Jan 28, 2015

@mgajdos Try the updated PR. I couldn't test it locally because I'm blocked on JERSEY-2430 and installing JDK7 on this machine is too much of a headache.

@cowwoc
Copy link
Contributor Author

cowwoc commented Jan 28, 2015

@mgajdos Also, #12 needs your help (I'm unable to proceed).

@mgajdos
Copy link
Contributor

mgajdos commented Jan 28, 2015

Gili, you're still trying to merge the change into 1.18.1 branch, see:

cowwoc  wants to merge 9 commits into jersey:1.18.1 from cowwoc:JERSEY-2429

The target branch should be changed to jersey:1.18.x. I am not sure but I guess you need to create a new pull request for that. Sorry, maybe I wasn't clear the first time.

@cowwoc
Copy link
Contributor Author

cowwoc commented Jan 28, 2015

@mgajdos Try #13

@mgajdos
Copy link
Contributor

mgajdos commented Jan 29, 2015

Merged new pull request (#13)

@mgajdos mgajdos closed this Jan 29, 2015
@cowwoc
Copy link
Contributor Author

cowwoc commented Jan 29, 2015

Good luck guys! I hope this helps.

@mgajdos
Copy link
Contributor

mgajdos commented Jan 29, 2015

@cowwoc Thank you for your contribution.

@cowwoc cowwoc deleted the JERSEY-2429 branch January 29, 2015 17:12
@cowwoc cowwoc restored the JERSEY-2429 branch February 2, 2015 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants