Skip to content
This repository was archived by the owner on Sep 29, 2020. It is now read-only.

Updated for full TypeScript Support#154

Open
nonara wants to merge 1 commit intojayphelps:masterfrom
nonara:ts-support
Open

Updated for full TypeScript Support#154
nonara wants to merge 1 commit intojayphelps:masterfrom
nonara:ts-support

Conversation

@nonara
Copy link

@nonara nonara commented Jun 9, 2019

  • Added TypeScript support (Primary changes in private/util.js->Decorate and lazy-initialize.js->handleDescriptor)
  • Added full types for all decorators
  • Added documentation and overloads to index.d.ts for intellisense
  • Fixed circular dependency issue (caused issue with tsc) (new file: private/meta.js)
  • Updated tests to work with both ts-node and babel
  • Updated outdated dependencies

By: Ron Spickenagel - http://www.github.com/ronspickenagel

@nonara
Copy link
Author

nonara commented Jun 9, 2019

Hi Jay! Wanted to let you know that I'm also happy to help maintain and address issues if you'd like the help. Thanks for all the great work. Feel free to reach out at ron@nonara.com or http://twitter.com/ron

@nonara nonara closed this Jun 9, 2019
+ Added TypeScript support (Primary changes in private/util.js->Decorate and lazy-initialize.js->handleDescriptor)
+ Added full types for all decorators
+ Added documentation and overloads to index.d.ts for intellisense
+ Fixed circular dependency issue (caused issue with tsc) (new file: private/meta.js)
+ Updated tests to work with both ts-node and babel
+ Updated outdated dependencies

By: Ron Spickenagel - http://www.github.com/ronspickenagel
@nonara nonara reopened this Jun 9, 2019
@nonara
Copy link
Author

nonara commented Jun 9, 2019

I just discovered after several days work that someone converted the whole thing to typescript! Go figure...

That said, here's why I think this is an easier approval:

  1. Not ported to new language

  2. Small footprint - minimal code changes from original. Nearly everything is preserved, with just a few alterations to accommodate TS

  3. Latest TypeScript is more feature rich - current index.d.ts uses modern types and methodology (like overloading)

  4. Documentation and typing is setup to support IntelliSense & TSC compiler gives correct suggestions/rejections for using decorators on the wrong types or with wrong arguments

  5. Centralized test base that runs on ts-node and babel

Please feel free to ask any questions! Hopefully it will be useful. Changes are marginal, but I recognize that I should have split each up into a separate commit so it's easier to see how each connects. If you'd like me to do that, let me know. I can reset and layer them on.

Cheers
Ron

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant