pci: add parent device address #431
Conversation
| ID: d.ProgrammingInterface.ID, | ||
| Name: d.ProgrammingInterface.Name, | ||
| }, | ||
| IOMMUGroup: d.IOMMUGroup, |
There was a problem hiding this comment.
I forgot add this in #430 so I am trying to sneakily add it here
There was a problem hiding this comment.
I moved this into a separate commit
christoph-zededa
force-pushed
the
pci_parent
branch
2 times, most recently
from
f809ed8 to
f931ac1
Compare
christoph-zededa
force-pushed
the
pci_parent
branch
from
f931ac1 to
1ee51ca
Compare
ffromani
left a comment
ffromani
left a comment
There was a problem hiding this comment.
I'm fine adding the parent address. Quick review, I'm probably overly cautious over backward compatibility
| // The PCI address of the parent device | ||
| ParentAddress string `json:"parent_address"` |
There was a problem hiding this comment.
I'm contemplating if we should add this at the end of the struct for abundant (excessive?) backward compatibility concerns. But OTOH we mostly (99%) serialize back/from YAML/JSON and clients just recompile, so it's probably OK
pkg/pci/pci_linux.go
Outdated
| if pciaddr.FromString(parentAddr) != nil { | ||
| return parentAddr | ||
| } | ||
|
|
||
| return "" |
There was a problem hiding this comment.
nit: I prefer to keep the happy path on the left:
if pciaddr.FromString(parentAddr) == nil {
return ""
}
return parentAddr
There was a problem hiding this comment.
Okay; I fixed it.
christoph-zededa
force-pushed
the
pci_parent
branch
from
1ee51ca to
3ba2663
Compare
the parent device address is important, too (like IOMMU group), when using pci-passthrough as the both devices should be passed through together Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
pci_parent
branch
from
3ba2663 to
330084d
Compare
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
all looks good to me, thank you @christoph-zededa :)
3 participants
the parent device address is important, too (like IOMMU group), when using pci-passthrough as the both devices should be passed through together