Skip to content

kafka_server role variable not being merged correctly with kafka_server_defaults #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradsheppard wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kafka_server role variable not being merged correctly with kafka_server_defaults #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tasks/kafka-cfg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
- name: "Generate kafka_server fact"
set_fact: kafka_server="{{ kafka_server_defaults | combine(kafka_server) }}"
- name: "Generate kafka_server_config fact"
set_fact: kafka_server_config="{{ kafka_server_defaults | combine(kafka_server) }}"

- name: "Generate kafka_healtcheck_address fact"
set_fact: kafka_healthcheck_address="{{ ((kafka_server.host_name | default('127.0.0.1')) == '') | ternary('127.0.0.1', kafka_server.host_name) }}"
set_fact: kafka_healthcheck_address="{{ ((kafka_server_config.host_name | default('127.0.0.1')) == '') | ternary('127.0.0.1', kafka_server_config.host_name) }}"
when: kafka_healthcheck_address == ""

- name: "Generate kafka_producer fact"
Expand All @@ -29,7 +29,7 @@
set_fact: kafka_zookeeper_connection_string="{{ kafka_zookeeper_hosts | join(':' ~ kafka_zookeeper_port ~ ',') }}:{{ kafka_zookeeper_port }}"

- name: "Generate the kafka hosts connection string"
set_fact: kafka_connection_string="{{ kafka_hosts | join(':' ~ kafka_server.port ~ ',') }}:{{ kafka_server.port }}"
set_fact: kafka_connection_string="{{ kafka_hosts | join(':' ~ kafka_server_config.port ~ ',') }}:{{ kafka_server_config.port }}"

- name: "Render and write out kafka configuration files"
template: src=usr/local/kafka/config/{{ item }}.j2 dest="{{ kafka_conf_dir }}/{{ item }}" mode=0640 owner={{ kafka_user }} group={{ kafka_group }}
Expand Down Expand Up @@ -62,14 +62,14 @@
- meta: flush_handlers

- name: "Wait for kafka to come up and open it's server port"
wait_for: port={{ kafka_server.port }} host={{ kafka_healthcheck_address }} connect_timeout={{ kafka_port_test_timeout_seconds }} timeout={{ kafka_port_test_timeout_seconds }}
wait_for: port={{ kafka_server_config.port }} host={{ kafka_healthcheck_address }} connect_timeout={{ kafka_port_test_timeout_seconds }} timeout={{ kafka_port_test_timeout_seconds }}
ignore_errors: yes
register: healthcheck
tags:
- kafka-healthcheck

- name: "Check kafka port test result"
fail: msg="Kafka port not open on host={{ kafka_healthcheck_address }}, port={{ kafka_server.port }}"
fail: msg="Kafka port not open on host={{ kafka_healthcheck_address }}, port={{ kafka_server_config.port }}"
when: healthcheck.elapsed is defined and (healthcheck.elapsed >= kafka_port_test_timeout_seconds and kafka_port_test_timeout_seconds > 0)
tags:
- kafka-healthcheck
Loading