Open
Conversation
xBA5ED
reviewed
Jun 27, 2022
| @notice Add a single address to the whitelist | ||
| @param _address the address to whitelist | ||
| */ | ||
| function addToWhitelist(address _address) external onlyProjectOwner { |
Member
There was a problem hiding this comment.
Idea: remove the single add/remove methods in favor of the multiple add/remove, the gas saved when deploying a version without those methods might outweigh the overhead of looping if you are just adding 1 address
| } | ||
|
|
||
| function supportsInterface(bytes4 _interfaceId) external pure override returns (bool) { | ||
| return _interfaceId == type(IJBFundingCycleDataSource).interfaceId; |
Member
There was a problem hiding this comment.
Make sure it also reflects implementing the ERC165 standard itself by returning true for the ERC165 interfaceId (Example OZ)
Member
Author
There was a problem hiding this comment.
Good catch, I forgot to || super
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a simple whitelisting possibility, via a datasource. The whitelist is managed by the project owner. Anyone can reuse the whitelist (by adding this datasource as funding cycle datasource).
This implementation uses a mapping of whitelisted addresses, and might therefore not be able to handle large whitelist (where other solutions might be more gas efficients, Merkle tree of the addresses for instance)