Open
Conversation
simon-something
commented
Nov 15, 2022
| /** | ||
| @notice The token which should be distributed | ||
| */ | ||
| address immutable tokenOut; |
simon-something
commented
Nov 15, 2022
| For clarity, we suggest changing the contract's name to reflect the tokenOut (ie SwapAllocatorDai) | ||
| */ | ||
| contract SwapAllocator is ERC165, Ownable, IJBSplitAllocator { | ||
| event SwapAllocated(address indexed beneficiary, address tokenIn, address tokenOut, uint256 amountIn, uint256 amountOut); |
Member
Author
There was a problem hiding this comment.
todo: natspec + ISwapAllocator
simon-something
commented
Nov 15, 2022
| @param _tokenIn The token to swap | ||
| @param _newDexes The array of new pool wrappers to add | ||
| */ | ||
| function addDex(address _tokenIn, IPoolWrapper[] calldata _newDexes) external onlyOwner { |
Member
Author
There was a problem hiding this comment.
todo: "addDexes "
Member
Author
There was a problem hiding this comment.
- override both add/remove with single/array
simon-something
commented
Nov 15, 2022
| address _beneficiary = _data.split.beneficiary; | ||
|
|
||
| // Keep record of the best pool wrapper. The pool address is passed to avoid having | ||
| // to find it again in the wrapper |
Member
Author
There was a problem hiding this comment.
// to find it again in the wrapper when calling swap()
simon-something
commented
Nov 15, 2022
| } | ||
| } | ||
|
|
||
| function swap( |
Member
Author
There was a problem hiding this comment.
adapt for eth (wrap if in, unwrap if out)
simon-something
commented
Nov 15, 2022
| _amountOut = _getAmountOut(_amountIn, reserve0, reserve1); | ||
| } | ||
|
|
||
| function swap( |
Member
Author
There was a problem hiding this comment.
adapt for eth (wrap/unwrap)
simon-something
commented
Nov 15, 2022
| registry = abi.decode(_registry, (address)); | ||
| } | ||
|
|
||
| function getQuote( |
Member
Author
There was a problem hiding this comment.
adapt for eth: convert jbTokens.ETH() to weth address
simon-something
commented
Nov 15, 2022
| factory = _factory; // uniV2 mainnet 0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f | ||
| } | ||
|
|
||
| function getQuote( |
Member
Author
There was a problem hiding this comment.
adapt for eth: convert jbTokens.ETH() to weth address
simon-something
commented
Nov 15, 2022
|
|
||
| @notice | ||
| */ | ||
| contract SwapAllocator { |
Member
Author
There was a problem hiding this comment.
wrapper, todo (fee via? Gov? Just best quote accross all?)
simon-something
commented
Nov 15, 2022
| import { Mainnet_UniswapV2 } from '../example/swapAllocator/poolWrappers/Mainnet_UniswapV2.sol'; | ||
|
|
||
| contract SwapAllocator_UniV2_Test is Test { | ||
| address constant _uniV2Factory = address(0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f); |
Member
Author
There was a problem hiding this comment.
add comment: needs to be hardcoded for the deterministic addressing
simon-something
commented
Nov 15, 2022
| vm.expectCall(_poolWrapper1, abi.encodeCall(IPoolWrapper.getQuote, (amountIn, jbLibraries().ETHToken(), _tokenOut))); | ||
| vm.expectCall(_poolWrapper2, abi.encodeCall(IPoolWrapper.getQuote, (amountIn, jbLibraries().ETHToken(), _tokenOut))); | ||
|
|
||
| //else check eth balance (token out == token in) |
simon-something
added
enhancement
|
great to see this coming to a finish line :) |
xBA5ED
reviewed
Nov 15, 2022
| // PoolAddress.getPoolKey(_token0, _token1, _fee) | ||
| // ); | ||
| // (uint160 _sqrtPriceX96, , , , , , ) = IUniswapV3Pool(_pair).slot0(); | ||
| // // Return amount out with "not so bad" precision (if not overflowing) : TODO: replace by uniV3 lib (there must be one) |
Member
There was a problem hiding this comment.
replace by uniV3 lib (there must be one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocator swapping a given tokenIn (specified in the splits data received) to a tokenOut (set at deployment), using the best quote received across a set of dexes.
The allocator should avoid reverting (if no swap is possible, then the unswapped tokenIn is sent), avoiding freezing the whole split distribution.
There is no slippage as the quote and swap are atomic, therefore the only sandwich protection is getting a quote in multiple dexes (this shouldn't be used for market with a single pool/low liquidity, as sandwich becomes easy)