Use reference to convert object to lua #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current push declaration is:
But
ToLuasatisfied with the reference&self(it doesn't need to own the instance).I don't see any reason to own the value inside push.
But owning makes hard to push nested structs with this generic
pushmethod, because we have convert nested items to owned (clone) to satisfypushdeclaration.This PR makes tiny backward-incompatible change and uses reference only to push objects ToLua.