Fix a floating point bug and introduce a small test suite#2
Open
benclifford wants to merge 2 commits intojcristovao:masterfrom
Open
Fix a floating point bug and introduce a small test suite#2benclifford wants to merge 2 commits intojcristovao:masterfrom
benclifford wants to merge 2 commits intojcristovao:masterfrom
Conversation
added 2 commits
October 12, 2016 10:30
These were being rendered with exponential notations which the openstreetmap API was erroring on. This commit switches to using fixed point representation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small latitudes and longitudes were previously formatted into an openstreetmap request using
show.For small values, this uses exponential notation (for example, 8e-2) which the API cannot accept.
This PR changes to fixed point representation and adds a simple over-the-network test (which can demonstrate the bug if used without the fixed point change)