Skip to content

fix(accordion): Accordion组件默认开启的状态时 state wrapperHeight 初始设置为0会导致动画错误 #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(accordion): Accordion组件默认开启的状态时 state wrapperHeight 初始设置为0会导致动画错误 #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/accordion/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default class AtAccordion extends AtComponent<
this.isCompleted = true
this.startOpen = false
this.state = {
wrapperHeight: 0
wrapperHeight: 'unset'
}
}

Expand Down Expand Up @@ -109,8 +109,9 @@ export default class AtAccordion extends AtComponent<
color: (icon && icon.color) || '',
fontSize: (icon && `${icon.size}px`) || ''
}
const contentStyle = { height: `${wrapperHeight}px` }

const contentStyle = {
height: wrapperHeight === 'unset' ? wrapperHeight : `${wrapperHeight}px`
}
if (this.isCompleted) {
contentStyle.height = ''
}
Expand Down
2 changes: 1 addition & 1 deletion types/accordion.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export interface AtAccordionProps extends AtComponent {
}

export interface AtAccordionState {
wrapperHeight: number
wrapperHeight: number | 'unset'
}

declare const AtAccordion: ComponentClass<AtAccordionProps>
Expand Down