Fixed toggle_snake_camel_pascal not handling single-word lowercase variables#17
Open
Anaminus wants to merge 1 commit intojdavisclark:masterfrom
Open
Fixed toggle_snake_camel_pascal not handling single-word lowercase variables#17Anaminus wants to merge 1 commit intojdavisclark:masterfrom
Anaminus wants to merge 1 commit intojdavisclark:masterfrom
Conversation
…riables When a variable is a single word that is lowercase, it is treated as camelCase so that it toggles to PascalCase, which is more convenient than doing nothing.
Contributor
Author
|
Just considered something: if you're toggling multiple variables, they'll go out of sync: Obviously, the toggle function can't know the expected state of the single-word variable. At least, not without some complexity that's probably not worth implementing. The question is, might it actually be better to do nothing to the single-word variable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to toggle a variable named
indexto PascalCase, and found that it did nothing! This is because the variable is neither snake_case nor camelCase, but simply lower case with no separator. This fix treats lower-case-no-separator as camelCase so that it converts to PascalCase, which is more convenient than doing nothing at all.