pyqt5

[pohmelie]

Nice idea to have pyqt5, I think. Probably I missed something with pyqt4 <-> pyqt5 difference, as they are pretty similar.

[kravietz]

I have tested this one and it does work without impairing the old interface - maybe worth adding to the mainstream?

[pohmelie]

It will be great! But probably there is still some issues with processes and/or threads, which we don't know about right now.

[ijstokes]

Is there anything we could do to help with merging this? @bollwyvl could do with having this merged for some work we're doing and we could plan to put aside time to help get the PR merged.

[bollwyvl]

A bit of background: we're generating PDF of Jupyter Notebooks with ghost, and it's pretty good. The issue that's tripping me up for a class of generation is in connecting to pages that use WebSockets, and a number of special flags, etc. need to be set, etc... so it might be more of an inconvenience than a requirement, as I haven't full explored that space. However, as I continue testing, I imagine I'll encounter limitations of QtWebKit, whether javascript, CSS or just craziness, as the pages I am rendering can indeed get pretty crazy.

Having done some more research on the matter: apparently, QWebKit hasn't been updated for some time. Thus, getting ghost to work with it's latest version would be nice, if easy, as we would get to the last state of improvement webkit is likely to get. A high-value goal for emulating desktop browsers even more closely would be the Qt5-only QtWebEngine, which is basically chromium. Among other things, you can connect to it from the chrome dev tools which is magic.

QtWebEngine is not supported by pyqt, but there is at least one example of using it via round-about methods... and may not expose all of the APIs ghost would need.

pyside2 does have support for QtWebEngine, but it's not ready yet.

So if really significant work is required to get ghost to work with qt5, it may be worth waiting until one of the upstreams supports QtWebEngine to invest significant work. Of the two possible upstreams, pyside is the one that would actually accept effort, as I couldn't even find the code for pyqt in non-dump-from.