fix(lib): solved bug related with utf-8 file names

[candreuv]

Fixes Issue

Closes #483

Description

Fixes a bug related with reading directories with special characters.

Check List

Check all the applicable boxes:

• [ x] I understand that my contributions needs to pass the checks;
• If I created new functions / methods, I documented them and add type hints;
• If I modified already existing code, I updated the documentation accordingly;
• [ x] The title of my pull request is a short description of the requested changes.

Screenshots

None

Note to reviewers

None

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.12%. Comparing base (40ed77b) to head (c96f6cb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   80.12%   80.12%           
=======================================
  Files          23       23           
  Lines        2038     2038           
=======================================
  Hits         1633     1633           
  Misses        405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jeertmans]

Hi @candreuv, thanks for your PR! When searching through the repository, I think it might be safer to also force UTF-8 encoding here:

manim-slides/manim_slides/config.py

Line 299 in 40ed77b

with open(path) as f:

also here

manim-slides/manim_slides/config.py

Line 316 in 40ed77b

with open(path, "w") as f:

and there

manim-slides/manim_slides/convert.py

Line 596 in 40ed77b

with open(dest, "w") as f:

as they might introduce similar bugs.

What do you think?

If you agree, could you also make those changes?

Finally, could you please add an entry to the CHANGELOG.md file?

[candreuv]

Hi @jeertmans,

In my experience, I think it would be wise to make the encoding changes you suggest. And of course, I will also update CHANGELOG.md.

[jeertmans]

Hi @candreuv, do you still plan on doing the aforementioned changes? :-)