Skip to content

Cassandra 2.1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jivemonkey wants to merge 5 commits into
base: cassandra-2.1
Choose a base branch
from
Open

Cassandra 2.1 #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f917dd
Adding the ability to give high tombstone ratio sstages compaction pr…
Dec 7, 2015
935f8bf
Removing the max tombstone ratio and rearranging the order of sstable…
Dec 8, 2015
5716dd9
Merge pull request #1 from newrelic-forks/jking/add_max_tombstone
Dec 8, 2015
faed6a4
Adding to comments
Dec 8, 2015
ff68901
Merge pull request #2 from newrelic-forks/jking/add_max_tombstone
Dec 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions ...egy/src/main/java/com/jeffjirsa/cassandra/db/compaction/TimeWindowCompactionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
import java.util.Iterator;
import java.util.TreeSet;
import java.util.concurrent.TimeUnit;
Expand All @@ -34,7 +35,11 @@
import com.google.common.collect.HashMultimap;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import org.apache.cassandra.dht.Range;
import org.apache.cassandra.dht.Token;
import org.apache.cassandra.io.sstable.Component;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -112,6 +117,7 @@ private List<SSTableReader> getNextBackgroundSSTables(final int gcBefore)
Set<SSTableReader> candidates = Sets.newHashSet(filterSuspectSSTables(uncompacting));

List<SSTableReader> compactionCandidates = new ArrayList<SSTableReader>(getNextNonExpiredSSTables(Sets.difference(candidates, expired), gcBefore));

if (!expired.isEmpty())
{
logger.debug("Including expired sstables: {}", expired);
Expand All @@ -123,25 +129,34 @@ private List<SSTableReader> getNextBackgroundSSTables(final int gcBefore)

private List<SSTableReader> getNextNonExpiredSSTables(Iterable<SSTableReader> nonExpiringSSTables, final int gcBefore)
{
// First get the a list of tables that could drop tombstones.
List<SSTableReader> sstablesWithTombstones = new ArrayList<>();
for (SSTableReader sstable : nonExpiringSSTables)
{
if (worthDroppingTombstones(sstable, gcBefore))
sstablesWithTombstones.add(sstable);
}

// If there are files that could be compacted because they reached their tombstone ratio, then clean them up.
// NOTE: You should set a the tombstone ratio and tombstone compaction interval high enough so you're not constantly compacting SSTables.
if(!sstablesWithTombstones.isEmpty())
{
// Compact the tables with the highest tombstone ratios first.
return Collections.singletonList(Collections.max(sstablesWithTombstones, (o1, o2) ->
Double.compare(o1.getEstimatedDroppableTombstoneRatio(gcBefore), o2.getEstimatedDroppableTombstoneRatio(gcBefore))));
}

// Now check for the most interesting tables.
List<SSTableReader> mostInteresting = getCompactionCandidates(nonExpiringSSTables);

if (mostInteresting != null)
{
return mostInteresting;
}

// if there is no sstable to compact in standard way, try compacting single sstable whose droppable tombstone
// ratio is greater than threshold.
List<SSTableReader> sstablesWithTombstones = new ArrayList<>();
for (SSTableReader sstable : nonExpiringSSTables)
else
{
if (worthDroppingTombstones(sstable, gcBefore))
sstablesWithTombstones.add(sstable);
}
if (sstablesWithTombstones.isEmpty())
return Collections.emptyList();

return Collections.singletonList(Collections.min(sstablesWithTombstones, new SSTableReader.SizeComparator()));
}
}

private List<SSTableReader> getCompactionCandidates(Iterable<SSTableReader> candidateSSTables)
Expand Down Expand Up @@ -389,4 +404,4 @@ public String toString()
cfs.getMinimumCompactionThreshold(),
cfs.getMaximumCompactionThreshold());
}
}
}