tools:::httpdPort is a dynamic variable#40
Open
psolymos wants to merge 2 commits intojeffreyhorner:masterfrom
Open
tools:::httpdPort is a dynamic variable#40psolymos wants to merge 2 commits intojeffreyhorner:masterfrom
psolymos wants to merge 2 commits intojeffreyhorner:masterfrom
Conversation
Make tools:::httpdPort a dynamic variable: wch/r-source@368f045#diff-511a7690b48f353bb2bb27e5ac70040466b0f9423837d502bda503717562ed3d
httpdPort is unexported, so I took the next minor version after the httpdPort() commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools:::httpdPortwas changed to a dynamic variable (tools:::httpdPort()) on Jan 17, 2015 (see this commit by K Hornik).The PR implements this change when checking the port in RStudio IDE. I also added the subsequent R version dependency (non exported function changes are not advertised in R NEWS, but I assumed the next minor version 3.2.0 to be appropriate).