Skip to content

Fix JENKINS-70842 by adding a depency#13

Open
cafuego wants to merge 3 commits intojenkinsci:masterfrom
UN-OCHA:bugfix/JENKINS-70842
Open

Fix JENKINS-70842 by adding a depency#13
cafuego wants to merge 3 commits intojenkinsci:masterfrom
UN-OCHA:bugfix/JENKINS-70842

Conversation

@cafuego
Copy link

@cafuego cafuego commented Mar 23, 2023

This PR fixes JENKINS-70842 by explicitly adding a dependency on the https://plugins.jenkins.io/apache-httpcomponents-client-4-api plugin and updating the plugin code that makes the HTTP request to work with the updated libraries.

Note that a build against a current Jenkins really also wants #12 to be merged first.

@cafuego
Copy link
Author

cafuego commented Mar 23, 2023

Tests failed because really this should be a PR against PR #12.

A locally built version that does have both sets of changes merged in works as expected when installed on a current LTS Jenkins and no longer errors out.

@emakaay
Copy link

emakaay commented May 11, 2023

Is there any ETA for this pull request ?

@basil
Copy link
Member

basil commented May 30, 2023

The Global Post Script plugin has an unresolved security vulnerability that includes a missing permission check allowing one to obtain configuration data. It was last released 5 years ago.

If the Global Post Script plugin is important to your organization, please ask your organization to assign someone a day or two a month to adopt the plugin, fix the unresolved security vulnerability, modernize the plugin, and release a new version.

@cafuego
Copy link
Author

cafuego commented May 30, 2023

@emakaay I built the plugin with both the security fix and the httpcomponents fix back in March. It works nicely for me. Attached is a zip with the build HPI and JAR files, in case you're happy to try them too. (I don't think I can commit to maintainership for this plugin)

global-post-script.zip

@gheine
Copy link

gheine commented Mar 13, 2024

@cafuego looks like the CVE fix has been merged. What needs to happen to get this PR merged also, and a new version of the plugin released?

@basil
Copy link
Member

basil commented Mar 13, 2024

See #13 (comment).

@michbu1
Copy link

michbu1 commented Sep 13, 2024

Any ETA for releasing official new version (with dependencies fixed and CVE resolved) ?

@basil
Copy link
Member

basil commented Sep 13, 2024

See #13 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants