Skip to content

Conversation

@i386
Copy link
Contributor

@i386 i386 commented May 29, 2017

…c revision when it no longer exists in HEAD

User suggested patch for JENKINS-25825. Not sure if this is right nor not but thought I could queue it up here for others to review.

@reviewbybees

…c revision when it no longer exists in HEAD
@ghost
Copy link

ghost commented May 29, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@stephenc stephenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like something which could, and should, be covered by a new test case.

@i386
Copy link
Contributor Author

i386 commented May 31, 2017

FYI this isn't mergable. Another problem reported on the ticket.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO-MERGE according to the comment from @i386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants