Skip to content

Conversation

@ARMS2025
Copy link

Description

I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that

In tests multipleRepositoriesSvn17, pollingExternalsForFileSvn16, and pollingExternalsForFileSvn17:

  • the req object:
    i) is created in AbstractSubversionTest.configureSvnWorkspaceFormat
    ii) during test execution calls the getParameter method with argument "svn.global_excluded_revprop", but is not stubbed, resulting in a mismatch stubbing.

In general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).

I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry (Not applicable)
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira (Not applicable)
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue (Not applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant