Skip to content

Conversation

@mark-cooke
Copy link

Hi @jessp01,

Thanks for opening the pull request for adding ci to devilspie2 - I hope it gets accepted.

I think it would be very useful, since it's API has changed a few times, to include Lua in the build matrix - so here's the necessary changes + a one-liner to verify the version.

I'd appreciate it if you'd include them into your original PR as I don't think dependent PRs across repos is very well supported on Github - and the maintainer already has 9 between us to deal with already, without interdependent ones too :)

Thanks,
Mark Cooke.

@mark-cooke mark-cooke changed the title Ci Add Lua to the build matrix Feb 21, 2025
@jessp01 jessp01 merged commit 78487e2 into jessp01:ci Feb 21, 2025
6 checks passed
@jessp01
Copy link
Owner

jessp01 commented Feb 21, 2025

Hi @mark-cooke ,

I think it would be very useful, since it's API has changed a few times, to include Lua in the build matrix - so here's the necessary changes + a one-liner to verify the version.

I agree. Merged.

The CI already proved itself useful as I found that the build fails with Clang >= 17. I submitted this pull to fix that: dsalt#42

Once merged, I'll reintroduce Clang testing to CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants