Add cookie banner for opt-in analytics #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analytics are now opt-in with a cookie consent banner to ensure compliance with GDPR guidelines.
There was a problem hiding this comment.
Pull Request Overview
This PR implements a cookie consent banner to comply with privacy regulations (GDPR/CCPA). The implementation adds user consent management for analytics tracking with opt-in/opt-out functionality.
- Adds a new shared library
@jetstream/ui/cookie-consent-bannerwith consent management utilities - Integrates consent-based analytics initialization for both Amplitude and Google Analytics
- Updates privacy documentation to reflect the new opt-in consent mechanism
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Adds path mapping for new cookie consent banner library |
| libs/shared/ui-core/src/analytics.tsx | Updates Amplitude initialization to respect consent opt-out flag |
| libs/shared/ui-app-state/src/lib/ui-app-state.ts | Adds global analytics consent state atom |
| libs/shared/cookie-consent-banner/* | New library providing cookie consent UI, storage, and analytics integration |
| apps/landing/pages/_document.js | Integrates conditional Google Analytics loading |
| apps/landing/pages/_app.js | Adds cookie consent banner to landing app |
| apps/jetstream/src/app/components/core/AppInitializer.tsx | Integrates consent banner and conditional GA in main app |
| apps/jetstream/src/app/components/settings/AnalyticsTrackingSetting.tsx | New settings component for managing analytics preferences |
| apps/landing/pages/privacy/index.tsx | Updates privacy policy removing "Do Not Track" section |
| apps/landing/pages/subprocessors/index.tsx | Updates data processor information with consent details |
| apps/api/src/app/controllers/auth.controller.ts | Adds OAuth validation and error handling improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/shared/cookie-consent-banner/src/lib/useConditionalGoogleAnalytics.ts
Outdated
Show resolved
Hide resolved
libs/shared/cookie-consent-banner/src/lib/useConditionalGoogleAnalytics.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/shared/cookie-consent-banner/src/lib/useConditionalGoogleAnalytics.ts
Show resolved
Hide resolved
Escape regex string - even though this is a hard-coded string passed in, it is better to be safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analytics are now opt-in with a cookie consent banner to ensure compliance with GDPR guidelines.