Added WebviewObjectConverter #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kerenr-jfrog
commented
Jun 12, 2025
kerenr-jfrog
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- Add a utility class for converting objects for WebView data exchange.
kerenr-jfrog
force-pushed
the
add_webview_object_converter
branch
from
4f73d49 to
d2b544d
Compare
kerenr-jfrog
added
safe to test
hadarshjfrog
suggested changes
Jun 16, 2025
hadarshjfrog
left a comment
hadarshjfrog
left a comment
There was a problem hiding this comment.
overall looks good - added some question and minor requests
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewObjectConverter.java
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewObjectConverter.java
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewObjectConverter.java
Outdated
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewObjectConverter.java
Outdated
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewObjectConverter.java
Show resolved
Hide resolved
tests/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewObjectConverterTest.java
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewObjectConverter.java
Show resolved
Hide resolved
hadarshjfrog
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.