Skip to content

Conversation

@kerenr-jfrog
Copy link
Contributor

@kerenr-jfrog kerenr-jfrog commented Jun 15, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

  • Added EventManager to handle events between the WebView and the IDE.
  • Added a Sender for pushing events to the WebView.
  • Added a Receiver for getting events from the WebView - need to add handling logic for each event.

@kerenr-jfrog kerenr-jfrog changed the title initial implementation of event handler Added Event Handler Jun 17, 2025
@kerenr-jfrog kerenr-jfrog changed the title Added Event Handler Add EventManager implementation for handling events from WebView and IDE Jun 17, 2025
@kerenr-jfrog kerenr-jfrog marked this pull request as ready for review June 17, 2025 08:06
Copy link

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm.
Mostly code cleaning issues.
But how can we test functionality here? even if it's complex - try to add just a one test for the browser - so we'll have some sanity - we can enrich it later.

@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@kerenr-jfrog kerenr-jfrog merged commit 0e97082 into jfrog:dev Jun 29, 2025
2 checks passed
@kerenr-jfrog kerenr-jfrog deleted the add_event_manager branch June 29, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants